-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Node: setMaintanceMode #74
Feature: Node: setMaintanceMode #74
Conversation
Personally I would change hasMaintanceMode into isInMaintenanceMode or inMaintenanceMode or something like that |
Thank you for your suggestion regarding the naming convention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey there! thanks so much for your contribution to p4j! just some small nitty changes, and then it should be good to go :)
src/main/java/com/mattmalec/pterodactyl4j/requests/action/AbstractNodeAction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mattmalec/pterodactyl4j/application/managers/NodeAction.java
Outdated
Show resolved
Hide resolved
Thank you for your feedback. I don't want to change the old function name but when you say it is okay then let's go. |
@mattmalec can we please merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super quick changes and i will approve + merge today
src/main/java/com/mattmalec/pterodactyl4j/application/entities/Node.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
This PR introduces the functionality to set a Node into Maintenance Mode.
API Doc:
https://dashflo.net/docs/api/pterodactyl/v1/